ValueFlow: Limit the combinations of arguments passed to subfunctions in normal analysis - #4950
Merged
danmar merged 1 commit intoApr 12, 2023
Conversation
… in normal analysis
danmar
approved these changes
Apr 12, 2023
Collaborator
There was a problem hiding this comment.
This has a dramatic effect on run time for me 👍
Checking lib/symboldatabase.cpp with main head:
real 1m19,580s
user 1m19,553s
sys 0m0,024s
Checking lib/symboldatabase.cpp with these changes:
real 0m14,697s
user 0m14,671s
sys 0m0,024s
At the same time when I check the whole "lib" folder the time-saving is ~1 minute so I assume that most of the checking is not affected much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.